Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proot: static by default, bump to 2017-10-15 #30495

Merged
merged 2 commits into from Oct 22, 2017
Merged

proot: static by default, bump to 2017-10-15 #30495

merged 2 commits into from Oct 22, 2017

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Oct 17, 2017 •
edited

Motivation for this change

There is no reason not to have it statically linked by default.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@veprbl
Copy link
Member Author

veprbl commented Oct 17, 2017 •
edited

cc @wavewave @nckx @makefu

@veprbl
Copy link
Member Author

veprbl commented Oct 17, 2017 •
edited

I also run into many problems with using proot with nixpkgs caused by bash scripts failing during builds (configure scripts and some pieces of stdenv). Example:

~/nix/store/qa70drryzanjlz1wwshpz60vhmbrr87k-proot-5.1.0/bin/proot \
  -b $HOME/nix:/nix nix-build . -p A nix-info

fails with

/nix/store/xy2lw4card1wml5s5s6qv1fx7gm702ib-patchelf-0.9/nix-support/setup-hook:
xrealloc: jobs.c:773: cannot allocate 8388608 bytes (933888 bytes allocated)

This seems to be a known problem: proot-me/proot#43. It seems like since release 5.1.0 in 2014 this problem was resolved, I guess, by proot-me/proot@51b0d41 . It would be nice to have updated proot in nixpkgs, I think.

@veprbl veprbl changed the title proot: static by default proot: static by default, bump to 2017-10-15 Oct 17, 2017
@nckx nckx merged commit 4333b94 into NixOS:master Oct 22, 2017
@nckx
Copy link
Member

nckx commented Oct 22, 2017

Thanks!

@veprbl veprbl deleted the patch-2 branch December 1, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@veprbl @nckx