Added .DS_Store into template/gitignore.ecr #5167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this should be in the gitignore of the project. if you are on a mac, I suggest you add |
|
Duplicate of #3462 |
|
No one describe about the incompatibility between the template and crystal itself...
IMHO, That's the reason why we don't have to add .DS_Store, but not the reason for "should not add" it. Anyway, sorry for the duplication. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could you add .DS_Store into .gitignore for Mac users including me?
Like as crystal itself
crystal/.gitignore
Line 1 in 3d48a96
Thanks!