open-vm-tools: Fix rebooting on NixOS #30718
Merged
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the package itself builds fine but the first travis build fails on an unrelated issue with |
|
Can you test, if that works? |
|
I've just tried here using ESX 6.5 and it works! |
|
\o/
…On Tue, Oct 24, 2017 at 10:16 AM Peter Hoeg ***@***.***> wrote:
I've just tried here using ESX 6.5 and it works!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#30718 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AADWltvOsNtlfQcZnUyKCWCiFrpuWF80ks5svZzSgaJpZM4QCuWe>
.
|
|
Ok I'll merge and then in a few days I'll backport it to stable |
|
I only tested it on stable... Should probably have mentioned that. |
|
:) Well I'm only in the position to test it once it hits Hydra. It's a very
low-risk change - it's not working right now and at worst the patch has no
effect.
…On Tue, Oct 24, 2017 at 12:30 PM Peter Hoeg ***@***.***> wrote:
I only tested it on stable... Should probably have mentioned that.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#30718 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AADWluk-wt8gqaFHjoYdAblBW1HVgchEks5svbxagaJpZM4QCuWe>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30717 - hopefully… untested ;)