awesomebump: 4.0 -> 5.1 #30728
Merged
awesomebump: 4.0 -> 5.1 #30728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edolstra
reviewed
Oct 23, 2017
|
|
||
| buildPhase = '' | ||
| cd Sources/utils/QtnProperty | ||
| unzip "${fetchurl { url = "https://github.com/kmkolasinski/QtnProperty/archive/master.zip"; sha256 = "1hd2bqxhv2w26b5xs5hwxc0s8q8z0bvlkz9zpnr814v8kwkqwp21"; } }" |
There was a problem hiding this comment.
Yes, good catch. I've hard-coded the git revision now.
pmiddend
force-pushed
the
awesomebump-5.1
branch
from
b50ab4c
to
f676103
Compare
pmiddend
force-pushed
the
awesomebump-5.1
branch
from
f676103
to
c9e08b5
Compare
then all the hacks are not necessary
Mic92
reviewed
Oct 24, 2017
| url = "https://github.com/kmkolasinski/AwesomeBump.git"; | ||
| rev = "Winx32v${version}"; | ||
| sha256 = "1c8b9jki0v8kzkvsvyv7q1w3s7j40br6ph15hh2xi0a1mpwckq56"; | ||
| fetchSubmodules = true; |
There was a problem hiding this comment.
By using the submodule qtnproperty should be in sync with AwesomeBump.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
awesomebump-5 is out now, I'd like to upgrade to the latest version. The build process is a bit complex due to the embedded QtnProperty dependency, but it seems to work. I'm a newbie to NixOS, so feel free to complain. :)
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)