Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-crypt: add runtime dependencies to PATH #30714

Merged
merged 1 commit into from Oct 23, 2017
Merged

git-crypt: add runtime dependencies to PATH #30714

merged 1 commit into from Oct 23, 2017

Conversation

phunehehe
Copy link
Contributor

@phunehehe phunehehe commented Oct 23, 2017 •
edited

Motivation for this change

git-crypt won't work if git and git-crypt are not in PATH. This surfaced after dbb8958. Test like this:

PATH= $(nix-build --no-out-link '<nixpkgs>' --attr git-crypt)/bin/git-crypt unlock
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@phunehehe phunehehe force-pushed the git-crypt-path branch 2 times, most recently from 0eb75fe to 17f6252 Compare October 23, 2017 10:58
@grahamc
Copy link
Member

grahamc commented Oct 23, 2017

Post a comment when this PR is ready :)

@phunehehe
Copy link
Contributor Author

@grahamc it is ready now :)

@phunehehe
git-crypt: add runtime dependencies to PATH
acbe3a8 
git-crypt won't work if git and git-crypt are not in PATH. This surfaced
after dbb8958. Test like this:

```
PATH= $(nix-build --no-out-link '<nixpkgs>' --attr git-crypt)/bin/git-crypt unlock
```
@phunehehe
Copy link
Contributor Author

(I pushed once more for a nicer commit message. Will stop now.)

@grahamc grahamc merged commit 346dcfd into NixOS:master Oct 23, 2017
@grahamc
Copy link
Member

grahamc commented Oct 23, 2017 •
edited

Thank you!

@phunehehe phunehehe deleted the git-crypt-path branch October 23, 2017 14:24
@phunehehe
Copy link
Contributor Author

@grahamc could you also cherry pick this to 17.09 please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@phunehehe @grahamc