Honor no-color option from spec command
#5168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior this change, `crystal spec` only recognized `--no-color` when
provided as child command additional arguments.
This worked:
$ crystal spec -- --no-color
However, this didn't:
$ crystal spec --no-color
This change ensures that option specified to `spec` command is passed
to child process.
Fixes #1587
Ref #4292
straight-shoota
approved these changes
Oct 23, 2017
RX14
approved these changes
Oct 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior this change,
crystal speconly recognized--no-colorwhen provided as child command additional arguments.This worked:
However, this didn't:
This change ensures that option specified to
speccommand is passed to child process.Thank you.
❤️ ❤️ ❤️
Fixes #1587
Ref #4292