Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apache-httpd: 2.4.28 -> 2.4.29 #30731

Merged
merged 2 commits into from Oct 24, 2017
Merged

apache-httpd: 2.4.28 -> 2.4.29 #30731

merged 2 commits into from Oct 24, 2017

Conversation

ghost
Copy link

@ghost ghost commented Oct 23, 2017

Motivation for this change

latest minor of 2.4

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@fpletz
Copy link
Member

fpletz commented Oct 24, 2017

The travis error is weird and I get another error trying to build perlPackages.ApacheTest:

…
cp lib/Apache/TestConfigParrot.pm blib/lib/Apache/TestConfigParrot.pm
cp lib/Apache/TestPerlDB.pm blib/lib/Apache/TestPerlDB.pm
cp lib/Apache/Test5005compat.pm blib/lib/Apache/Test5005compat.pm
Manifying 15 pod documents
running tests
"/nix/store/raylbbdkg4yz21c44fwcv63bzvj7a1i1-perl-5.24.2/bin/perl" -Iblib/arch -Iblib/lib \
t/TEST  -clean
[warning] setting ulimit to allow core files
ulimit -c unlimited; /nix/store/raylbbdkg4yz21c44fwcv63bzvj7a1i1-perl-5.24.2/bin/perl /tmp/nix-build-perl-Apache-Test-1.40.drv-0/Apache-Test-1.40/t/TEST -clean
Use of uninitialized value $proto in socket at lib/Apache/TestServer.pm line 383.
make: *** [Makefile:973: test_clean] Error 2
builder for ‘/nix/store/9gw0rxighxfj18rmpkv45iaxad2h1ycl-perl-Apache-Test-1.40.drv’ failed with exit code 2
error: build of ‘/nix/store/9gw0rxighxfj18rmpkv45iaxad2h1ycl-perl-Apache-Test-1.40.drv’ failed

@ghost
Copy link
Author

ghost commented Oct 24, 2017

Odd, I'm testing now with sandbox enabled using the appliance linked from https://nixos.org/nixos/download.html.
This is odd as I get different errors running within the nixos image and on travis. The other travis job says something about a perl compile flag. The local build failed with another perl dependency error:
virtualbox_nixos 17 09 1812 36a4dc392a x86_64-linux _24_10_2017_08_50_52

@ghost
Copy link
Author

ghost commented Oct 24, 2017

So it looks like the errror comes from this line: https://metacpan.org/source/SHAY/Apache-Test-1.40/lib/Apache/TestServer.pm#L383. I've reproduced the error by running nix-shell -p gzip --run "nix-env -f https://github.com/NixOS/nixpkgs/archive/master.tar.gz -iA perlPackages.libapreq2" from within a docker container. The error looks like it is unable to spin up a test server or something. I think this issue may have been lurking in master and not necessarily related to the bump to 2.4.29. I am going to see about a patch or something.

@globin globin merged commit 5a07d16 into NixOS:master Oct 24, 2017
@globin
Copy link
Member

globin commented Oct 24, 2017

Merged since this failure already exists on master and shouldn't block this, but feel free to fix this nonetheless :)

@ghost ghost deleted the bump-apache-httpd branch October 24, 2017 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants