Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parenthesis to all occurences of expect_raises #5098

Conversation

straight-shoota
Copy link
Member

Spin-off from #5096

@asterite
Copy link
Member

Sorry for the sarcastic reply above (which I just deleted), but I don't see the point of adding parentheses to these calls.

@straight-shoota
Copy link
Member Author

I was reacting to a comment on my pull request #5096 where it was suggested for the new code to have parenthesis. While obviously it's not required, it would at least make sense to use a coherent style throughout the stdlib.
But of course, this is just about calls to one single method.

So well, I don't really care either way. But maybe there are some other thoughts about this?

@asterite
Copy link
Member

I don't think every comment out there needs to be turned into a PR. In fact, I'd advise against that given that without first discussing it (preferably in the mailing list)

@asterite
Copy link
Member

I think we can close this. There's no 👍 yet. I understand that sometimes parentheses are used and sometimes not, many times I thought maybe we should just force parentheses so it's all consistent, but then we'd have to write property(:x) and such. So in the end it's a matter of style, and sometimes using parentheses and sometimes not is OK, it's just a small syntax detail.

@ysbaddaden ysbaddaden closed this Oct 27, 2017
@straight-shoota straight-shoota deleted the jm-parenthesis-expect_raises branch October 27, 2017 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants