Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xcbuild: add SDKROOT by default to the wrappers #30299

Merged
merged 1 commit into from Oct 11, 2017
Merged

xcbuild: add SDKROOT by default to the wrappers #30299

merged 1 commit into from Oct 11, 2017

Conversation

copumpkin
Copy link
Member

This fixes #30269 and lets us do things like xcrun -find cc, for example.

cc @matthewbauer

Motivation for this change

#30269

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@copumpkin
xcbuild: add SDKROOT by default to the wrappers
f92e097 
This fixes NixOS#30269 and lets us do things like `xcrun -find cc`, for
example.
@copumpkin
Copy link
Member Author

I'll probably also upgrade xcbuild later. There are no new official releases but the current one has a nasty bug where it runs build steps out of order and master has a fix for that, so I'm just going to build that unless you object.

@matthewbauer
Copy link
Member

Looks good! Keep track of some of the darwin.* stuff after this is merged because they can sometimes break from changes like these.

@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Oct 10, 2017
@copumpkin copumpkin merged commit 71e0dbd into NixOS:master Oct 11, 2017
@copumpkin
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

xcrun from xcbuild doesn't -find things
3 participants
@copumpkin @matthewbauer @LnL7