New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds cdpfgl programs into nix. #30291
Conversation
description = "Continuous data protection for GNU/Linux (cdpfgl)."; | ||
maintainers = "Olivier Delhomme"; | ||
license = licenses.gpl3; | ||
platforms = platforms.linux; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to maintain this package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
I'm not sure of what it means but as I'm already the core developer of the project I would say why not. Do I have to fill something somewhere ?
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just add yourself as dupbit
to lib/maintainers.nix
and add yourself to this package:
meta = {
maintainers = [ dupgit ];
};
As a consequence you will receive emails from hydra, when something regarding the build went wrong. We may consult you, when people are making changes to this package like applying updates. I have also summarized all information here: https://nixos.wiki/wiki/Get_Involved#Becoming_a_Nixpkgs_maintainer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Thanks.
name = "cdpfgl-${version}"; | ||
version = "0.0.11"; | ||
|
||
buildInputs = [ pkgconfig intltool glib sqlite jansson libmicrohttpd curl ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pkgconfig should go into nativeBuildInputs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And probably intltool
too.
Please squash the commits and change the name of the PR to follow the convention (init at...) |
squashing can be also done by us on merge. The maintainer attribute however we can not add on our own. |
Don't know how to do this I have done some mess in my own fork. Destroying it and redo the job is probably my best option :/ |
Motivation for this change
This adds cdpfgl (continuous data protection for GNU/Linux) latest version (0.0.11) into nix.
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)