Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds cdpfgl programs into nix. #30291

Closed
wants to merge 0 commits into from
Closed

Adds cdpfgl programs into nix. #30291

wants to merge 0 commits into from

Conversation

dupgit
Copy link
Contributor

@dupgit dupgit commented Oct 10, 2017

Motivation for this change

This adds cdpfgl (continuous data protection for GNU/Linux) latest version (0.0.11) into nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

description = "Continuous data protection for GNU/Linux (cdpfgl).";
maintainers = "Olivier Delhomme";
license = licenses.gpl3;
platforms = platforms.linux;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to maintain this package?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

I'm not sure of what it means but as I'm already the core developer of the project I would say why not. Do I have to fill something somewhere ?

Thanks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add yourself as dupbit to lib/maintainers.nix and add yourself to this package:

  meta = {
    maintainers = [ dupgit ];
  };

As a consequence you will receive emails from hydra, when something regarding the build went wrong. We may consult you, when people are making changes to this package like applying updates. I have also summarized all information here: https://nixos.wiki/wiki/Get_Involved#Becoming_a_Nixpkgs_maintainer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Thanks.

name = "cdpfgl-${version}";
version = "0.0.11";

buildInputs = [ pkgconfig intltool glib sqlite jansson libmicrohttpd curl ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkgconfig should go into nativeBuildInputs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And probably intltool too.

@peterhoeg
Copy link
Member

Please squash the commits and change the name of the PR to follow the convention (init at...)

@Mic92
Copy link
Member

Mic92 commented Oct 13, 2017

squashing can be also done by us on merge. The maintainer attribute however we can not add on our own.

@dupgit
Copy link
Contributor Author

dupgit commented Oct 13, 2017

Don't know how to do this I have done some mess in my own fork. Destroying it and redo the job is probably my best option :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants