Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pim-data-exporter #29657

Merged
merged 2 commits into from Sep 22, 2017
Merged

Add pim-data-exporter #29657

merged 2 commits into from Sep 22, 2017

Conversation

JohnMH
Copy link
Contributor

@JohnMH JohnMH commented Sep 22, 2017

Motivation for this change

The KDE app pim-data-exporter wasn't listed before, and I needed to copy my config from another machine. Figured other people might find this useful.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@JohnMHarrisJr, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ttuegel, @vandenoever and @peterhoeg to be potential reviewers.

@Mic92 Mic92 merged commit b292438 into NixOS:master Sep 22, 2017
@Mic92
Copy link
Member

Mic92 commented Sep 22, 2017

Thanks!

@JohnMH
Copy link
Contributor Author

JohnMH commented Sep 22, 2017

Just realized both changed files include tab indentation.. Yikes.

@Mic92
Copy link
Member

Mic92 commented Sep 22, 2017

oh, you might want to enable http://editorconfig.org/ in your editor to get the correct settings for nixpkgs

@JohnMH
Copy link
Contributor Author

JohnMH commented Sep 22, 2017

Issue was with my Emacs config, sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants