Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zulu: init 9.0.0.15 #29652

Merged
merged 1 commit into from Sep 29, 2017
Merged

zulu: init 9.0.0.15 #29652

merged 1 commit into from Sep 29, 2017

Conversation

NeQuissimus
Copy link
Member

Motivation for this change

JDK 9 release today

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

I threw this into an sbt build of mine and everything built fine.

I am unable to test the Darwin version but it should work fine...

Pinging @copumpkin @rbvermaa to try Darwin.
We may also want to point openjdk on Darwin at this (Does anybody know why we have two derivations for Zulu 1.8.x - openjdk-darwin and zulu? Both claim to work on Darwin, only one on Linux...)

@NeQuissimus NeQuissimus added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) 9.needs: community feedback 9.needs: port to stable A PR needs a backport to the stable release. labels Sep 21, 2017
@NeQuissimus NeQuissimus merged commit 4f132af into NixOS:master Sep 29, 2017
@NeQuissimus NeQuissimus deleted the zulu9 branch September 29, 2017 13:06
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants