Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
JDK 9 release today
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)I threw this into an
sbt
build of mine and everything built fine.I am unable to test the Darwin version but it should work fine...
Pinging @copumpkin @rbvermaa to try Darwin.
We may also want to point
openjdk
on Darwin at this (Does anybody know why we have two derivations for Zulu 1.8.x -openjdk-darwin
andzulu
? Both claim to work on Darwin, only one on Linux...)