Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opencascade: remove 6.5.5 and 6.6.0 #29650

Merged
merged 1 commit into from Sep 27, 2017
Merged

opencascade: remove 6.5.5 and 6.6.0 #29650

merged 1 commit into from Sep 27, 2017

Conversation

disassembler
Copy link
Member

@disassembler disassembler commented Sep 21, 2017 •
edited

Motivation for this change

I think we should remove these. opencascade no longer provides unauthenticated access to versions on their site (you have to go through a drupal login to access private files requiring signing up for an account). Only dependency on opencascade is freecad and it is already pointing at the oce version that remains and builds fine. PR also removes the override for freecad opencascade version since opencascade and opencascade_oce are the same now.

related to #28643

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@disassembler, thanks for your PR! By analyzing the history of the files in this pull request, we identified @viric, @vcunat and @rycee to be potential reviewers.

@joachifm
Copy link
Contributor

@viric is listed as the maintainer.

@disassembler
Copy link
Member Author

also for context, IRC logs:

2017-09-03 13:12:05 disasm viric: was trying to switch to opencascade 7.2.0 to see if it would fix failures, but that tarball is in a private drupal requiring authentication (free registration). Any suggestions at how I could obtain the binary from nix build process? Pinging you since you're the maintainer.
2017-09-03 14:38:12 viric disasm: Hm I don't know. Maybe you are supposed to download it with nix-prefetch-url ?
2017-09-03 14:38:16 viric disasm: or similar.
2017-09-03 14:38:26 viric disasm: I use OCE these days
2017-09-03 14:41:26 disasm viric: ooh, should we just replace it with that?
2017-09-03 14:42:20 viric disasm: isn't there also oce?
2017-09-03 14:43:48 disasm viric: ah, yes there is an oce package already.

@globin globin merged commit 672a402 into NixOS:master Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@disassembler @mention-bot @joachifm @globin