-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing IGMP protocol and multicast support #51
Comments
Sounds good! I suggest working on it in small pieces and seeking review early, as I try to ensure the quality of code in smoltcp stays very high. |
@podhrmic This is done, right? |
@whitequark there is a pending PR #236 but I got to a halt with the |
@podhrmic That PR is for fragmentation but this issue is for IGMP; I thought IGMP fully works now |
Yes, I believe IGMP support was added in #178 |
Hello, for our application I need smoltcp to handle multicast packets (the application communicates over multicast). I am happy to do that and implement this functionality to smoltcp, but I would like to get some pointers and guidance first.
EthernetProtocol::IGMP
with underlying logicdst_addr()
against the list of multicast MAC addresses we are subscribed to (here: https://github.com/m-labs/smoltcp/blob/master/src/iface/ethernet.rs#L244 )iface.poll()
Does it sound like a good approach to you?
The text was updated successfully, but these errors were encountered: