Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ecryptfs module: init #30195

Merged
merged 1 commit into from Oct 20, 2017
Merged

ecryptfs module: init #30195

merged 1 commit into from Oct 20, 2017

Conversation

edef1c
Copy link
Member

@edef1c edef1c commented Oct 7, 2017 •
edited

Motivation for this change

Currently, ecryptfs support is coupled to security.pam.enableEcryptfs, but one might want to use ecryptfs without enabling the PAM functionality. This PR splits it out into a boot.supportedFilesystems switch.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
  • Tested via tests/ecryptfs.nix
  • Fits CONTRIBUTING.md.
  • Extend it to work with boot.initrd.supportedFilesystems too (?)
  • Write an additional NixOS test for this functionality, separate from the current tests/ecryptfs.nix (?)

@edef1c
nixos/ecryptfs: init
a411d72 
Currently, ecryptfs support is coupled to `security.pam.enableEcryptfs`, but one
might want to use ecryptfs without enabling the PAM functionality. This commit
splits it out into a `boot.supportedFilesystems` switch.
@joachifm
Copy link
Contributor

cc @obadz

@obadz obadz merged commit ea35bc9 into NixOS:master Oct 20, 2017
@obadz
Copy link
Contributor

obadz commented Oct 20, 2017

looks good, thx.

@edef1c edef1c deleted the ecryptfs-module branch October 20, 2017 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@edef1c @joachifm @obadz