Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oauth2_proxy: default address updated #30173

Merged
merged 1 commit into from Oct 20, 2017
Merged

oauth2_proxy: default address updated #30173

merged 1 commit into from Oct 20, 2017

Conversation

dmjio
Copy link
Member

@dmjio dmjio commented Oct 6, 2017 •
edited

Go's http library will fail to parse this otherwise.
golang/go#19297

Motivation for this change

To fix default behavior

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dmjio
oauth2_proxy: default address updated
5b530d4 
Go will fail to parse this otherwise.
golang/go#19297
@joachifm
Copy link
Contributor

joachifm commented Oct 7, 2017

Would this affect 17.09 as well? If so I suppose this needs to be cherry-picked.

@joachifm joachifm merged commit 815bebf into NixOS:master Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dmjio @joachifm