Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openafs-client: don't remove kernel module on stop #30183

Merged
merged 1 commit into from Oct 8, 2017
Merged

openafs-client: don't remove kernel module on stop #30183

merged 1 commit into from Oct 8, 2017

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Oct 7, 2017

Otherwise it cannot re-insert the kernel module after a kernel upgrade
when boot kernel != running kernel.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
openafs-client: don't remove kernel module on stop
912ec46 
Otherwise it cannot re-insert the kernel module after a kernel upgrade
when boot kernel != running kernel.
@Mic92
Copy link
Member Author

Mic92 commented Oct 7, 2017

mhm. Looks like nobody is maintaining this anyway.

@Mic92 Mic92 merged commit eefae49 into NixOS:master Oct 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Mic92