selenium-server-standalone: 2.53.0 -> 3.6.0 #30186
Conversation
| --add-flags ${optionalString chromeSupport "-Dwebdriver.chrome.driver=${chromedriver}/bin/chromedriver"} \ | ||
| --add-flags "org.openqa.grid.selenium.GridLauncher" | ||
| --add-flags "org.openqa.grid.selenium.GridLauncherV3" |
There was a problem hiding this comment.
it looks like pkgs/development/tools/selenium/selendroid/default.nix needs also the new GridLauncherV3 argument.
There was a problem hiding this comment.
Thx for the hint. I updated it as well.
| @@ -23,7 +23,7 @@ stdenv.mkDerivation rec { | |||
| makeWrapper ${jdk}/bin/java $out/bin/selendroid-selenium \ | |||
| --add-flags "-Dfile.encoding=UTF-8" \ | |||
| --add-flags "-cp \"$out/share/lib/selendroid/${name}.jar:${selenium-server-standalone}/share/lib/${selenium-server-standalone.name}/${selenium-server-standalone.name}.jar\"" \ | |||
| --add-flags "org.openqa.grid.selenium.GridLauncher" | |||
| --add-flags "org.openqa.grid.selenium.GridLauncherV3" | |||
There was a problem hiding this comment.
I also suspect it needs to be updated: http://selendroid.io/ (websites states it is compatible with v3, but probably only in the latest version).
It would be great if you could do some basic testing (see if it can connect to the selenium server)
There was a problem hiding this comment.
How would a basic test look like (I've got no experience with selendroid)? Maybe checking if devices can register like in the getting started docs?
There was a problem hiding this comment.
I also have never heard of selendroid before this pull request. I you can reach http://localhost:4444/wd/hub/status after starting this should be enough. I mainly want to make sure it can properly use the new selenium version.
There was a problem hiding this comment.
Allright I tested it and it seems to startup fine with current androidsdk from nixpkgs. I didn't test to start an actual browser though, just startup and the status endpoint.
|
Thanks! |
Motivation for this change
Package update.
Things done
htmlunit driver has been updated as well.
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)