flat-plat: 20170917 -> 20171005 and renamed to materia-theme #30175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Oct 7, 2017
pkgs/top-level/all-packages.nix
Outdated
| @@ -19078,6 +19076,8 @@ with pkgs; | |||
|
|
|||
| martyr = callPackage ../development/libraries/martyr { }; | |||
|
|
|||
| materia-theme = callPackage ../misc/themes/materia-theme { }; | |||
There was a problem hiding this comment.
Is this worth an entry in pkgs/top-level/aliases.nix or would consider it a new project now?
There was a problem hiding this comment.
Probably no package depends on Flat-Plat. So the renaming would not have effect in other packages. I think the aliases is not worth in this case. Users of Flat-Plat would rename it in the configuration. Maybe a comment in file all-packages.nix or a mention of the old name in the description of the new package would help users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)