Update Boost to 1.65 and make it default #29814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterhoeg
reviewed
Sep 30, 2017
| ginVer = "1.5"; | ||
| gwtVer = "2.7.0"; | ||
| in | ||
| stdenv.mkDerivation rec { | ||
| name = "RStudio-${version}"; | ||
|
|
||
| buildInputs = [ cmake boost163 zlib openssl R qt5.full qt5.qtwebkit qt5.qtwebchannel libuuid unzip ant jdk makeWrapper pandoc ]; | ||
| buildInputs = [ cmake boost zlib openssl R qt5.full qt5.qtwebkit qt5.qtwebchannel libuuid unzip ant jdk makeWrapper pandoc ]; |
There was a problem hiding this comment.
You want to clean up the nativeBuildInputs while at it?
|
Ugh, Github requested reviews automatically because I accidentially pushed the wrong branch. Sorry. |
peti
reviewed
Oct 12, 2017
| @@ -1,4 +1,4 @@ | |||
| { callPackage, boost155, boost162, boost163, openssl_1_1_0, haskellPackages, darwin, libsForQt5 }: | |||
| { callPackage, boost155, boost162, openssl_1_1_0, haskellPackages, darwin, libsForQt5 }: | |||
There was a problem hiding this comment.
This build needs both boost155 and boost162?
There was a problem hiding this comment.
It's a subpackage tree, some altcoins seem to need older Boosts.
peti
approved these changes
Oct 12, 2017
|
Let's merge this in several days if noone objects; I'll be watching Hydra for possible fallout. |
8 tasks
Encrypted devices: don't override crytpoModules, fix example
Signed-off-by: Austin Seipp <aseipp@pobox.com>
Commit 271d3f7 ("prometheus service: globalConfig.labels is obsolete") removed globalConfig.labels. Update the test config accordingly.
As far as I can tell, we've had this test since 2015, but it was never enabled.
Refactor Steam so that native steam-run can be built as a free package and expose it so that Hydra builds needed i686 packages.
This packages up the Starcraft II headless Linux client provided by Blizzard for machine learning research.
sc2-headless: init at 3.17
I wrongly assumed that was the default when reviewing the PR.
This is needed now after NixOS#27672.
Also cleanup inputs.
Not built by default. Also add enablePython flag (enabled by default) and cleanup a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update the default package. It brings fixes for NVCC so that we can use new CUDA toolkit 9.0 with default Boost (which we need due to GCC 6 default). Also NumPy support is improved.
I've made packages that overrode Boost to a newer one use the default version. RStudio update is needed to fix build.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)I work on a system built with this Boost for some time, but don't have resources to test all packages.