Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

closure-compiler: 20170218 -> 20170910 #29823

Merged
merged 1 commit into from Sep 30, 2017
Merged

closure-compiler: 20170218 -> 20170910 #29823

merged 1 commit into from Sep 30, 2017

Conversation

lukateras
Copy link
Member

@lukateras lukateras commented Sep 26, 2017 •
edited

Motivation for this change

Hasn't been updated in a while, HTTP -> HTTPS, use idiomatic makeWrapper, unpackPhase.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jb55
Copy link
Contributor

jb55 commented Sep 27, 2017 via email

@lukateras
Copy link
Member Author

Removed trailing whitespace.

@peterhoeg peterhoeg merged commit 0bf3f4b into NixOS:master Sep 30, 2017
@lukateras lukateras deleted the closure-compiler/20170910 branch October 1, 2017 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukateras @jb55 @peterhoeg