Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rhino: enable on Darwin #29824

Merged
merged 2 commits into from Sep 28, 2017
Merged

Rhino: enable on Darwin #29824

merged 2 commits into from Sep 28, 2017

Conversation

berdario
Copy link
Contributor

Motivation for this change

When I worked on #29759
I had allowBroken == true 🤦‍♂️

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Sep 27, 2017
@LnL7 LnL7 merged commit d84d8af into NixOS:master Sep 28, 2017
@berdario
Copy link
Contributor Author

@LnL7 can you also merge this into release-17.09?

@LnL7
Copy link
Member

LnL7 commented Sep 28, 2017

I just did (1f3087b) 😄

@LnL7 LnL7 added the 8.has: port to stable A PR already has a backport to the stable release. label Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: port to stable A PR already has a backport to the stable release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@berdario @LnL7