Compiler: remove macro def
#5040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
reviewed
Sep 26, 2017
| @@ -3266,7 +3259,7 @@ module Crystal | |||
| @doc_enabled = !!@wants_doc | |||
| pop_def | |||
|
|
|||
| node = Def.new name, args, body, receiver, block_arg, return_type, (is_macro_def || @is_macro_def), @yields, is_abstract, splat_index, double_splat: double_splat, free_vars: free_vars | |||
| node = Def.new name, args, body, receiver, block_arg, return_type, @is_macro_def, @yields, is_abstract, splat_index, double_splat: double_splat, free_vars: free_vars | |||
There was a problem hiding this comment.
Is @is_macro_def argument still needed?
There was a problem hiding this comment.
Yes, a def that mentions @type inside macro code is a macro def. So the concept exists and still remains, you just don't have to make it explicit with macro def.
RX14
approved these changes
Sep 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2565
Since a long time now
macro defhas no use and can be replaced with a regulardefthat mentions@typeinside macro code. The logic is that if@typeisn't mentioned there's no need for the method to be instantiated for each particular subtype of the class.macro defwasn't used at all in the whole source code, except a few specs. These specs were kept, though, because macro defs are a concept of their own.