Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/iso-image.nix: add top-level /version.txt file #29820

Merged
merged 1 commit into from Sep 27, 2017

Conversation

bjornfor
Copy link
Contributor

@bjornfor bjornfor commented Sep 26, 2017

Motivation for this change

This makes it easy to identify which NixOS version is written to an USB
stick without actually booting it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bjornfor
Copy link
Contributor Author

Ok, I see the version number exists in various places now (/loader/entries/*, /isolinux/isolinux.cfg). But a top-level version file cannot hurt.

@dezgeg
Copy link
Contributor

dezgeg commented Sep 26, 2017

Sounds fine to me except it should probably use config.system.nixosVersion so it's consistent with what's in isolinux.cfg.

@bjornfor
Copy link
Contributor Author

Good point. Fixed.

@bjornfor bjornfor changed the title nixos/iso-image.nix: add /version.txt file with lib.nixpkgsVersion nixos/iso-image.nix: add top-level /version.txt file Sep 27, 2017
This makes it easy to identify which NixOS version is written to an USB
stick without actually booting it.
@fpletz fpletz added this to the 17.09 milestone Sep 27, 2017
@fpletz fpletz merged commit 3c6eb3a into NixOS:master Sep 27, 2017
@bjornfor bjornfor deleted the add-version-file-to-iso branch September 28, 2017 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants