Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

peco: 0.2.10 -> 0.5.1 #29937

Merged
merged 1 commit into from Sep 29, 2017
Merged

peco: 0.2.10 -> 0.5.1 #29937

merged 1 commit into from Sep 29, 2017

Conversation

tsaeger
Copy link
Contributor

@tsaeger tsaeger commented Sep 29, 2017

Motivation for this change

Wanted newer version of peco

Supersedes #29936

Things done

Simplified recipe to use glide to install depends.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@tsaeger tsaeger mentioned this pull request Sep 29, 2017
Closed
8 tasks
orivej
orivej suggested changes Sep 29, 2017
View reviewed changes
Copy link
Contributor

@orivej orivej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Derivations may not access network during the build phase.
go2nix should help update it with dependencies.

@tsaeger
Copy link
Contributor Author

tsaeger commented Sep 29, 2017

@orivej thanks for the review - I'll take a look at go2nix and send an updated patch.

@tsaeger
Copy link
Contributor Author

tsaeger commented Sep 29, 2017

bump

@orivej orivej merged commit e216cd4 into NixOS:master Sep 29, 2017
@tsaeger tsaeger deleted the pr/peco-0.51 branch October 2, 2017 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsaeger @orivej