Report limited editors to admin and only to admin #556
Conversation
| @@ -29,6 +29,14 @@ | |||
| <li><a href="[% c.uri_for_action('/report/show', 'ArtistsDisambiguationSameName') %]">[% l('Artists with disambiguation the same as the name') %]</a></li> | |||
| </ul> | |||
|
|
|||
| [% IF c.user.is_account_admin -%] | |||
There was a problem hiding this comment.
Other than not outputting the link here, where does it restrict access to account admins?
There was a problem hiding this comment.
Oops, fixed in cc1a4fd#diff-c720a88e431a4eb472afdd86f5d7206fR12
yvanzo
force-pushed
the
mbs-9357-part-2-admin-report
branch
from
0b31118
to
cc1a4fd
Compare
|
#557 changes the user-visible name to "new" editor, but I think it's fine to keep "limited" here. |
|
|
||
| use MusicBrainz::Server::Constants qw( $EDITOR_MODBOT ); | ||
|
|
||
| with 'MusicBrainz::Server::Report::EventReport'; |
| AND ( email_confirm_date IS NULL | ||
| OR member_since < NOW() - INTERVAL '2 weeks' | ||
| OR (SELECT COUNT(*) FROM edit WHERE eor.id = edit.editor AND edit.status = 2 AND edit.autoedit = 0) < 10 | ||
| )"; |
There was a problem hiding this comment.
Is it currently unordered, or ordered by name elsewhere? Should we order by member_since DESC instead? It seems like it'd be useful for admins to see the most recent accounts at the top of the list.
There was a problem hiding this comment.
I guess @Freso or @reosarevok will be looking at this report the most, so however they'd want it ordered.
There was a problem hiding this comment.
Yes. Actually, rows are ordered by id at line 11. Greatest ID being the most recent, it is the same as ordering by member_since.
Allow admins to quickly view beginner/limited editors (most recent first), with name, email, website and biography, and to possibly delete them. Because of the email, only admins are granted access to this report.
yvanzo
force-pushed
the
mbs-9357-part-2-admin-report
branch
from
22d6305
to
b49de61
Compare
No description provided.