Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport sysdig/bcc modules #29933

Merged
merged 2 commits into from Sep 29, 2017
Merged

Backport sysdig/bcc modules #29933

merged 2 commits into from Sep 29, 2017

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Sep 29, 2017 •
edited

Motivation for this change

Let's call it a usability bug that people don't know how to enable sysdig/bcc kernel modules correctly.
Also see:

#17683
#29913

cc @orivej

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
nixos/bcc: init module
1e32fe3 
Looks trival, but it is easy to make the mistake
to add linuxPackages.bcc to systemPackages,
which breaks if the not the default kernel is used.

(cherry picked from commit 44b6a15)
@Mic92
nixos/sysdig: init module
3493757 
(cherry picked from commit 5572062)
@Mic92 Mic92 added the 8.has: port to stable A PR already has a backport to the stable release. label Sep 29, 2017
@Mic92 Mic92 merged commit f332307 into NixOS:release-17.09 Sep 29, 2017
@Mic92 Mic92 deleted the backport-tracing branch October 15, 2017 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej approved these changes

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @orivej