Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

peco: 0.2.10 -> 0.5.1 #29936

Closed
wants to merge 1 commit into from
Closed

peco: 0.2.10 -> 0.5.1 #29936

wants to merge 1 commit into from

Conversation

tsaeger
Copy link
Contributor

@tsaeger tsaeger commented Sep 29, 2017

Motivation for this change

Wanted newer version of peco

Things done

Simplified recipe to use glide to install depends.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@tsaeger tsaeger mentioned this pull request Sep 29, 2017
Merged
8 tasks
@tsaeger
Copy link
Contributor Author

tsaeger commented Sep 29, 2017

superseded by #29937

@tsaeger tsaeger closed this Sep 29, 2017
@orivej
Copy link
Contributor

orivej commented Sep 29, 2017

Derivations may not access network during the build phase.
go2nix should help update it with dependencies.

@tsaeger
Copy link
Contributor Author

tsaeger commented Sep 29, 2017

ah! I started looking at go2nix - I will revisit and send updated patch to #29937

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsaeger @orivej