Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LibLLVM::IS_50 constant #5058

Merged
merged 1 commit into from Sep 29, 2017
Merged

Conversation

Sija
Copy link
Contributor

@Sija Sija commented Sep 29, 2017

SSIA

asterite
asterite previously approved these changes Sep 29, 2017
@akzhan
Copy link
Contributor

akzhan commented Sep 29, 2017

Why not to build cycle in bash from 5 down to 3?)

@ysbaddaden
Copy link
Contributor

This is no supporting, but making LLVM5 the default LLVM version to compile against. There is a difference.

@Sija
Copy link
Contributor Author

Sija commented Sep 29, 2017

@ysbaddaden It supports using llvm-5.0 postfixed versions, not LLVM itself. Title is copied from #5013 btw.

@ysbaddaden
Copy link
Contributor

Yup, which was just recently merged, because when set at the top of the list, it will be tried out first, thus prefering LLVM5 over any other version, thus making it the default.

It may be fine, thought I'm not sure it has been tested much. I'm not even using Crystal with LLVM5 myself. The latest stable is compiled against LLVM 3.9 and current master against LLVM4.

@luislavena
Copy link
Contributor

Hello,

The change in #5013 was to try for LLVM 4 prior others. That assumes that v4 is now considered stable in most of the distributions, however, v5 needs more testing.

Making that the default when detecting LLVM v5 might not be good. I might suggest adjust this so IS_50 is available but leave the auto-detection out, at least for now.

Cheers.

@asterite asterite dismissed their stale review September 29, 2017 16:26

Yeah, LLVM 5 shouldn't be the default

@Sija
Copy link
Contributor Author

Sija commented Sep 29, 2017

fair 'nuff, I'll revert the changes except LibLLVM::IS_50 constant. @asterite are you ok with that?

@asterite
Copy link
Member

@Sija I'm not the one that gave opinions in this thread :-P

@Sija Sija changed the title Support LLVM 5.0 postfixed versions Add LibLLVM::IS_50 constant Sep 29, 2017
@asterite
Copy link
Member

What I mean is, I don't want to be the one everyone has to consult before making a decision.

@Sija
Copy link
Contributor Author

Sija commented Sep 29, 2017

@asterite understandable, I just asked you because of your PR approval :)

@RX14 RX14 added this to the Next milestone Sep 29, 2017
@RX14 RX14 merged commit 7e3b642 into crystal-lang:master Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants