-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LibLLVM::IS_50
constant
#5058
Conversation
Why not to build cycle in bash from 5 down to 3?) |
This is no supporting, but making LLVM5 the default LLVM version to compile against. There is a difference. |
@ysbaddaden It supports using llvm-5.0 postfixed versions, not LLVM itself. Title is copied from #5013 btw. |
Yup, which was just recently merged, because when set at the top of the list, it will be tried out first, thus prefering LLVM5 over any other version, thus making it the default. It may be fine, thought I'm not sure it has been tested much. I'm not even using Crystal with LLVM5 myself. The latest stable is compiled against LLVM 3.9 and current master against LLVM4. |
Hello, The change in #5013 was to try for LLVM 4 prior others. That assumes that v4 is now considered stable in most of the distributions, however, v5 needs more testing. Making that the default when detecting LLVM v5 might not be good. I might suggest adjust this so Cheers. |
Yeah, LLVM 5 shouldn't be the default
fair 'nuff, I'll revert the changes except |
15d644d
to
2d2357d
Compare
@Sija I'm not the one that gave opinions in this thread :-P |
What I mean is, I don't want to be the one everyone has to consult before making a decision. |
@asterite understandable, I just asked you because of your PR approval :) |
SSIA