Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes: 1.7.1 -> 1.7.8 #29923

Merged
merged 1 commit into from Oct 11, 2017
Merged

kubernetes: 1.7.1 -> 1.7.8 #29923

merged 1 commit into from Oct 11, 2017

Conversation

NeQuissimus
Copy link
Member

Motivation for this change

Update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@offlinehacker
Copy link
Contributor

I will do an update on our kubernetes cluster and if it works, I'll merge. Btw k8s 1.8 is out, did you try it out?

@NeQuissimus
Copy link
Member Author

@offlinehacker Sounds good. And no, I was expecting issues and figured an up-to-date 1.7 would be a good step 1 :D

@NeQuissimus
Copy link
Member Author

FYI, I am running the tests against 1.8.0 now, maybe I will just update this PR with it.

@NeQuissimus
Copy link
Member Author

@offlinehacker They changed some stuff with RBAC that I am unable to figure out. I believe it is mostly due to kubernetes/kubernetes#49638
I don't have much experience with K8s RBAC, so the fix may or may not be simple.
For the moment, 1.7.7 looks to work. 1.8.0 does not. I am not even sure if it is an issue with our tests or the module itself...

@NeQuissimus
Copy link
Member Author

@offlinehacker I updated to 1.7.8, still LGTM :)

@NeQuissimus NeQuissimus changed the title kubernetes: 1.7.1 -> 1.7.7 kubernetes: 1.7.1 -> 1.7.8 Oct 5, 2017
@offlinehacker
Copy link
Contributor

I will take a look what's with v1.8, in a meantime let's merge this, thanks :)

@offlinehacker offlinehacker merged commit 29f4775 into NixOS:master Oct 11, 2017
@NeQuissimus NeQuissimus deleted the kube_1_7_7 branch October 11, 2017 12:56
@NeQuissimus
Copy link
Member Author

@offlinehacker I have no idea what happened but I think something broke the tests even for 1.7.x :)
Noticed today, wanted to give 1.8.1 another try... I am giving up on 1.8 for now, sorry...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@matejc matejc Awaiting requested review from matejc

@copumpkin copumpkin Awaiting requested review from copumpkin

Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NeQuissimus @offlinehacker