Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cudatoolkit: move libcu[...] to lib output #29925

Closed
wants to merge 1 commit into from
Closed

cudatoolkit: move libcu[...] to lib output #29925

wants to merge 1 commit into from

Conversation

jyp
Copy link
Contributor

@jyp jyp commented Sep 29, 2017

where [...] is blas, fft*, rand and solver.

This fixes #29798. Namely it makes the above libs visible to
tensorflow (and presumably other cudatoolkit.lib users)

Motivation for this change

Fixing #29798

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jyp
cudatoolkit: move libcu[...] to lib output
a09b107 
where [...] is blas, fft*, rand and solver.

This fixes NixOS#29798.  Namely it makes the above libs visible to
tensorflow (and presumably other cudatoolkit.lib users)
@jyp
Copy link
Contributor Author

jyp commented Sep 29, 2017

@edolstra Please let me know if this is better than my other pull request. Thanks!

@edolstra edolstra self-assigned this Oct 2, 2017
@edolstra
Copy link
Member

edolstra commented Oct 2, 2017

Hm, this makes the .lib output about a thousand times bigger (from ~416 KiB to 590 MiB), which is unfortunate for packages like opensubdiv/blender that only need libcudart.so. Maybe we need more granularity? (E.g. a separate output for libcudart.)

@jyp
Copy link
Contributor Author

jyp commented Oct 3, 2017

@TravisWhitaker gave a workaround for the problem which I'll PR soon. However my opinion is still that cudatoolkit is effectively broken in master and I still recommend reverting your patch until a working solution is found.

@jyp jyp closed this Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@edolstra edolstra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tensorflow cannot find libcusolver.so.8.0
2 participants
@jyp @edolstra