Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plasma: 5.10.5 -> 5.11.1 #30305

Merged
merged 4 commits into from Oct 19, 2017
Merged

plasma: 5.10.5 -> 5.11.1 #30305

merged 4 commits into from Oct 19, 2017

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Oct 11, 2017 •
edited

Motivation for this change

KDE Plasma feature release!

Cryfs support is removed from the new plasma-vault feature as I do not want to package & maintain this.

Also had to update Digikam and libqtav as Digikam would not build.

Update (2017-10-18): Bugfix release 5.11.1 was made, PR updated .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/) (not all but I have tested getting a fully functional desktop)
  • Fits CONTRIBUTING.md.

cc @ttuegel

@adisbladis adisbladis changed the title Plasma 5 11 plasma: 5.10.5 -> 5.11.0 Oct 11, 2017
@adisbladis adisbladis force-pushed the plasma-5_11 branch 3 times, most recently from c2ed8c2 to 48d059b Compare October 11, 2017 09:47
@bkchr
Copy link
Contributor

bkchr commented Oct 11, 2017

Do you have any problems with SDDM after this update?
I'm also using qt 5.9.2, but that worked before the update without any problems.

@adisbladis
Copy link
Member Author

adisbladis commented Oct 11, 2017 •
edited

@bkchr I'm not aware of any problems though I have only tested with auto login.

Update: There is some problem with the sddm greeter. I'll look into it.

@adisbladis
Copy link
Member Author

@bkchr This only happens with the breeze theme, not with the official sddm themes.

@bkchr
Copy link
Contributor

bkchr commented Oct 11, 2017

Nice that you can reproduce it. Any idea what could be the problem?

@peterhoeg
Copy link
Member

We are still using sddm 0.15 while 0.16 was just released so maybe upgrading that as well helps?

@adisbladis
Copy link
Member Author

@peterhoeg I tried that and it does not resolve the issue.

@peterhoeg peterhoeg mentioned this pull request Oct 12, 2017
Merged
8 tasks
@ttuegel
Copy link
Member

ttuegel commented Oct 12, 2017

Thanks! I'll check this out in a bit.

Regarding plasma-vault, have you checked that it works with encfs?

@adisbladis
Copy link
Member Author

@ttuegel Yes I tested it out and it works fine.

@ttuegel
Copy link
Member

ttuegel commented Oct 12, 2017

@adisbladis I can't see any reason for the segmentation fault in the SDDM greeter, either. It might help if you rebuilt Qt with debugging enabled.

@peterhoeg
Copy link
Member

With cryfs in master, do you feel like adding back the cryfs support to the vault?

@bkchr
Copy link
Contributor

bkchr commented Oct 13, 2017

Sddm works on my PC with Nvidia GPU, but on my Laptop with Intel GPU is segfaults. Maybe it is somehow related to the GPU?

@ttuegel
Copy link
Member

ttuegel commented Oct 13, 2017 •
edited

Maybe it is somehow related to the GPU?

That is possible.

We may need to give serious consideration to dropping SDDM. From reading Mesa bug reports, it turns out that KDE upstream does not test anything involving Xorg and their developers only use Wayland, implying that they do not test SDDM either.

EDIT: @bkchr What version of Mesa are you using on the machine experiencing the crash? There is a Mesa update in staging which may help.

@adisbladis
Copy link
Member Author

@peterhoeg I've added back cryfs support to vault. Thanks for the cryfs package :)
@ttuegel I'm also getting the crash with current mesa from master.

@ttuegel
Copy link
Member

ttuegel commented Oct 13, 2017

I'm also getting the crash with current mesa from master.

master has mesa-17.1.10, but staging has mesa-17.2.2.

If the crash is fixed with mesa-17.2.2, then we can just wait. Otherwise, we will need to file a bug report upstream with KDE.

@adisbladis adisbladis mentioned this pull request Oct 14, 2017
Merged
8 tasks
@ttuegel
Copy link
Member

ttuegel commented Oct 15, 2017

Some users have reported that running SDDM with HiDPI enabled causes crashing due to some problem in Qt. The Plasma theme may exercise some bad code path. We should try disabling HiDPI as in sddm/sddm#701.

@adisbladis
Copy link
Member Author

adisbladis commented Oct 15, 2017 •
edited

@ttuegel Beatiful! That was it.

I applied the fix as a patch changing the default behaviour.
I considered just changing the nixos service but felt this was more appropriate and easier to track with the next sddm upgrade when this will hopefully have been fixed.

@bkchr
Copy link
Contributor

bkchr commented Oct 15, 2017

Ahh that is nice. I have a question regarding Wayland, @ttuegel do you think we could start to enable it in nixos for kde?

@ttuegel
Copy link
Member

ttuegel commented Oct 15, 2017

do you think we could start to enable it in nixos for kde?

Not yet. Just like we have a custom startkde script to start an X11 session, we need custom startplasma and startplasmacompositor scripts.

@bkchr
Copy link
Contributor

bkchr commented Oct 16, 2017

@adisbladis hmm, for me it still does not work :/ Did you also upgrade your mesa?

@adisbladis
Copy link
Member Author

@bkchr No I did not upgrade my mesa. I saw in the sddm issue tracker that there are a lot (at least 3) of these issues causing similar symptoms.

@bkchr
Copy link
Contributor

bkchr commented Oct 17, 2017 •
edited

@adisbladis I tried to find the commit that is responsible for the linker error. Git bisect says that the following commit is the first one, where the build fails: d32f7f4

This does not look that suspicious ^^

Will you update to 5.11.1?

@adisbladis adisbladis changed the title plasma: 5.10.5 -> 5.11.0 plasma: 5.10.5 -> 5.11.1 Oct 18, 2017
@adisbladis
Copy link
Member Author

adisbladis commented Oct 18, 2017 •
edited

Updated PR to plasma 5.11.1.
Also applied a commit from @bkchr that disables the gold linker for all things Qt.

This fixes linker errors with plasma-integration after qtuickcontrols2 was added as a dependency.
Presumably fixes some other packages too.

Rebased PR on master.

@ttuegel
Copy link
Member

ttuegel commented Oct 18, 2017

hmm, for me it still does not work :/ Did you also upgrade your mesa?

@adisbladis
I tried again with 4a55bbb, and I still get a blank screen with SDDM, too.

@adisbladis
Copy link
Member Author

@ttuegel Interestingly enough I get the same behaviour now after rebasing even with the patch applied so it seems like we have uncovered yet another bug in sddm.

@adisbladis
Copy link
Member Author

adisbladis commented Oct 19, 2017 •
edited

digikam and libqtav were merged to master (43ebfb5...27b7192), dropped those commits and rebased.

@ttuegel
Copy link
Member

ttuegel commented Oct 19, 2017 •
edited

we have uncovered yet another bug in sddm.

Nope, we're hitting this QML cache invalidation bug:
https://bugreports.qt.io/browse/QTBUG-62302

You can work around it by removing /var/lib/sddm/.cache/sddm-greeter/qmlcache.

I will see about backporting this patch to our Qt. 😃

EDIT: We actually have this patch in Qt 5.9.2. It seems like maybe if the last caches were generated with Qt 5.9.1, they still aren't invalidated properly. To be safe, I think we just need to obliterate the QML cache before every SDDM start.

@bkchr
Copy link
Contributor

bkchr commented Oct 19, 2017

Ohh nice for finding that!

@ttuegel
Copy link
Member

ttuegel commented Oct 19, 2017

Merged in f7de0da.

@ttuegel ttuegel closed this Oct 19, 2017
@ttuegel ttuegel merged commit 7132cbd into NixOS:master Oct 19, 2017
@peterhoeg
Copy link
Member

Has anybody else been unable to launch KDE since the upgrade to plasma 5.11? I have 2 machines here and while one is perfectly fine, the other just shows a black screen after logging in from sddm. I need to manually wipe /var/lib/sddm/.cache/sddm-greeter/qmlcache for sddm to come up despite @ttuegel rm in the setup script as well. All I see is kded5 core dumping.

@bkchr
Copy link
Contributor

bkchr commented Oct 23, 2017

I had the same problem for my laptop, I also needed to rm the directory by hand. But I don't know if I need to do that everytime.

@ttuegel
Copy link
Member

ttuegel commented Oct 23, 2017

the other just shows a black screen after logging in from sddm

This doesn't sound like an issue with the SDDM cache, it sounds like an issue with the qmlcache for Plasma! Do you have any qmlcache directories in $HOME?

@bkchr
Copy link
Contributor

bkchr commented Oct 23, 2017

Ohh, for me this happened to be SDDM crashing.

@peterhoeg peterhoeg mentioned this pull request Oct 25, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adisbladis @bkchr @peterhoeg @ttuegel