translate-toolkit: Init at 2.2.5 #30307
Conversation
|
Is this supposed to be used as a python library or a set of command-line tools? |
|
In the end it's both as it has a lot of executable tools ( http://docs.translatehouse.org/projects/translate-toolkit/en/latest/commands/index.html ) but also an API ( http://docs.translatehouse.org/projects/translate-toolkit/en/latest/api/index.html ). I am only using the tools and I think those are more important/popular. Is there an easy way to make it both a normal library package and a set of command-line tools in nixpkgs? |
| @@ -0,0 +1,31 @@ | |||
| { stdenv, fetchFromGitHub, python3Packages, makeWrapper }: | |||
|
|
|||
| python3Packages.buildPythonApplication rec{ | |||
There was a problem hiding this comment.
We don't store python applications here, as we we build pythonPackages against multiple python versions.
Please change to buildPythonLibrary here and remove the python3Packages prefix.
| propagatedBuildInputs = with python3Packages; [ | ||
| six diff-match-patch lxml python-Levenshtein chardet pycountry | ||
| ]; | ||
| checkInputs = with python3Packages; [ pytest ]; |
There was a problem hiding this comment.
This would make building against python2 impossible. Please move all libraries into the header and remove the python3Packages.
{ stdenv, fetchFromGitHub, python3Packages, makeWrapper, six, diff-match-patch, ... }:
|
Packages which can be used as both stay in |
phile314
force-pushed
the
translate-toolkit
branch
from
900e06e
to
f001937
Compare
|
The translate-toolkit is now a normal python library. I added a reference in |
|
Could you actually move the package to |
| @@ -20710,6 +20710,36 @@ in { | |||
|
|
|||
| transaction = callPackage ../development/python-modules/transaction { }; | |||
|
|
|||
| translate-toolkit = buildPythonPackage rec { | |||
There was a problem hiding this comment.
We are moving Python expressions out of pkgs/top-level/python-packages.nix into pkgs/development/python-modules/<module>/default.nix.
Please move the expression there, and call it from pkgs/top-level/python-packages.nix using callPackage ../development/python-modules/<package> { };.
|
(triage) @phile314, are you still willing to push this forward? |
|
I am actually working on this (packaging weblate). |
|
Feel free to take over or close this, I no longer have the time to push this. |
|
@jtojnar please open a new PR with your version. |
|
See #48726 |
Motivation for this change
Add the translation-toolkit tools:
http://toolkit.translatehouse.org/
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)