geoclue2: 2.4.3 -> 2.4.7 and add wrapGAppsHook #30314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
reviewed
Oct 11, 2017
| @@ -18,7 +18,7 @@ stdenv.mkDerivation rec { | |||
|
|
|||
| buildInputs = libintlOrEmpty ++ | |||
| [ intltool glib json_glib libsoup geoip | |||
| dbus dbus_glib avahi | |||
| dbus dbus_glib avahi wrapGAppsHook | |||
There was a problem hiding this comment.
wrapGAppsHook should be moved to nativeBuildInputs. And while you are at it, can you also move intltool there?
geoclue2 without GNOME requires glib_networking in order to make HTTPS connections to location providers. Additionally, geoclue2 crashes if an NMEA provider is found on the network without GSettings support. Also moved intltool to nativeBuildInputs as per good practices.
jtojnar
approved these changes
Oct 11, 2017
Mic92
added
the
9.needs: port to stable
|
also backported to 17.09. |
samueldr
removed
the
9.needs: port to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
geoclue2 on my machine failed to contact Mozilla because it was unable to find glib_networking. On GNOME systems this will be set by environment variable, but without GNOME it isn't. Adding
glib_networkingvia thewrapGAppsHooksolved this issue.Additionally, when geoclue2 found an NMEA source on the local network via Avahi, it would crash on
No GSettings schemas are installed on the systemwithout that hook.This PR solves both problems, as well as upgrading the package to the latest upstream.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)