trezor-agent: add systemd service #29831
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trezor-agent now splits agents into different packages. This commit still points trezor_agent to the trezor-specific agent to maintain backwards compatibility. We should probably abstract this a bit into ledgernano_agent, keepkey_agent, etc
Needed for the system service
peterhoeg
reviewed
Sep 27, 2017
nixos/modules/programs/gnupg.nix
Outdated
| systemd.user.services.trezor-agent = { | ||
| description = "Trezor GnuPG Agent"; | ||
|
|
||
| wantedBy = [ "multi-user.target" ]; |
There was a problem hiding this comment.
multi-user.target isn't a valid target for user sessions.
peterhoeg
reviewed
Sep 27, 2017
| owner = "romanz"; | ||
| rev = "v${version}"; | ||
| sha256 = "1wrmf76016ksx394l1xknnqn08sc5pid5ihri619cd83zsxpkfvk"; | ||
| }}/agents/trezor"; | ||
|
|
There was a problem hiding this comment.
What's wrong with the pypi package?
There was a problem hiding this comment.
The author uploaded a new version, I'm going to update this PR this evening (-0700)
|
multi-user.target isn't a valid target for user sessions.
ha I actually just remembered this before I went to sleep last night and
was going to fix it when I woke up (fixing now)
|
|
What's wrong with the pypi package?
As far as I can tell it hasn't been uploaded yet...
https://pypi.python.org/pypi/trezor_agent/
|
Allows you to use your Trezor as a GnuPG agent
jb55
force-pushed
the
trezor-agent-service
branch
from
58512f2
to
2ed846b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Option to enable a trezor-agent service that allows you to use your Trezor as a GnuPG agent. This builds upon #28656.
Closes #28656
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)