Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyramid: fix propagated builds #29844

Merged
merged 1 commit into from Sep 27, 2017
Merged

pyramid: fix propagated builds #29844

merged 1 commit into from Sep 27, 2017

Conversation

makefu
Copy link
Contributor

@makefu makefu commented Sep 27, 2017

hupper and plaster need to be propagated to dependent packages

Motivation for this change

When updating pyramid upstream packages in #29602 the new dependencies were not propagated and dependent packages failed to build due to the missing hupper dependency (see https://hydra.nixos.org/eval/1396335 ).

This PR fixes this issues described in #29602 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

hupper and plaster need to be propagated to dependent packages
@makefu makefu requested a review from FRidh as a code owner September 27, 2017 12:36
@globin globin merged commit 3abee35 into NixOS:master Sep 27, 2017
@makefu
Copy link
Contributor Author

makefu commented Sep 27, 2017

thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants