guile-gnome: fix build by building gwrap with guile-2.0 #29836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyp See discussion in [1]. [1]: NixOS#29732
|
Wait do not merge, I just discovered that you can set the guile version directly in pkgs/top-level/all-packages.nix, so I'll update this PR to do that instead some time. |
Apparently gwrap will not compile with guile-2.2 [1], even though the news for version 1.9.15 says it "allows" Guile 2.2 [2]: > it will _not_ compile using 2.2 Furthermore, it seems like it isn't being developed anymore either [1]: > Also note that g-wrap itself is not being further developed anymore, > it is recommended for new projects to use Guile's dynamic FFI. Also, guile-gnome-2.16.5 is apparently compatible with guile-2.2 [3], but I'm not sure how they built it with guile-2.2 because gwrap 1.9.15 (latest release) apparently doesn't build with guile-2.2. (And certainly when I try to build gwrap 1.9.15 with guile-2.2 it doesn't work. Maybe it can be made to work with certain compile flags, but I haven't pursued that further due to [1] anyway.) This is why guile-gnome is still on 2.16.4 here. Because, although 2.16.5 can still (apparently) build with guile-2.0.14, guile_2_0 is only at guile-2.0.13. So to update guile-gnome to 2.16.5, guile_2_0 would first have to be updated to 2.0.14. [1]: http://lists.nongnu.org/archive/html/g-wrap-dev/2016-08/msg00001.html [2]: http://www.nongnu.org/g-wrap/news.html [3]: https://www.gnu.org/software/guile-gnome/news.html
vyp
force-pushed
the
fix/guile-gnome
branch
from
640bb7a
to
11e911b
Compare
|
👆 Done |
orivej
reviewed
Sep 28, 2017
|
|
||
| src = fetchurl { | ||
| url = "http://ftp.gnu.org/pub/gnu/guile-gnome/guile-gnome-platform/${name}.tar.gz"; | ||
| url = "http://ftp.gnu.org/pub/gnu/guile-gnome/${pname}/${name}.tar.gz"; |
| preConfigure = '' | ||
| ./autogen.sh | ||
| ''; | ||
| preConfigure = "./autogen.sh"; |
There was a problem hiding this comment.
- Multiline strings are preferred for scripts, even for single line ones.
autoreconfHookis generally preferred to./autogen.sh.- This package builds even without autoreconf.
Could you also add GUILE_AUTO_COMPILE = 0; to silence warnings?
|
Fixed the nitpicks myself, thanks for your work on the guile stuff! If you are still at it |
|
Thanks @globin and thanks for reviewing @orivej! I think for guile-xcb, it just hasn't been updated to work with guile 2.2, so I made a PR for fixing that: #29916. But I'm not 100% sure because this line mentions 2.2: https://github.com/mwitmer/guile-xcb/blob/db7d5a393cc37a56f66541b3f33938b40c6f35b3/configure.ac#L12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes the build for guile-gnome, which currently does not work: #29732 (comment)
@taktoa I also went ahead and removed you from maintainers for gwrap since it seems to only be a guile related package. (There's nothing to 'maintain' anyway since if you look at the commit messages in this PR, you'll see that it seems as though it's not being developed anymore, but wanted to ping you just in case.)
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)