Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bower2nix: 3.1.1 -> 3.2.0 #29833

Merged
merged 1 commit into from Sep 27, 2017
Merged

bower2nix: 3.1.1 -> 3.2.0 #29833

merged 1 commit into from Sep 27, 2017

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Sep 27, 2017

Motivation for this change

New bug fix release.

/cc @peterhoeg -- if you regen uchiwa/bower-packages.nix with this version it will work.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • [/] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@peterhoeg
Copy link
Member

Cool, thanks! I saw 3.3 upstream - was that a typo or not ready yet?

@rvl
Copy link
Contributor Author

rvl commented Sep 27, 2017

Sorry for the confusion. 3.2.0 is the latest and 3.3.0 doesn't exist yet. I got ahead of myself and bumped the package.json version to 3.3.0 before even releasing 3.2.0.

@peterhoeg peterhoeg merged commit 7f3cb3f into NixOS:master Sep 27, 2017
@peterhoeg
Copy link
Member

Cool, thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants