Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makeself: 2.2.0 -> 2.3.1 #30744

Merged
merged 1 commit into from Oct 24, 2017
Merged

makeself: 2.2.0 -> 2.3.1 #30744

merged 1 commit into from Oct 24, 2017

Conversation

jammerful
Copy link
Contributor

Motivation for this change

Version 2.3 has new feature I need.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 merged commit b653131 into NixOS:master Oct 24, 2017
@copumpkin
Copy link
Member

copumpkin commented Oct 24, 2017 •
edited

@GrahamcOfBorg makeself

@copumpkin
Copy link
Member

(just trying out the new bot!)

GrahamcOfBorg
GrahamcOfBorg reviewed Oct 24, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

error: Please be informed that this pseudo-package is not the only part of
Nixpkgs that fails to evaluate. You should not evaluate entire Nixpkgs
without some special measures to handle failing packages, like those taken
by Hydra.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamcOfBorg GrahamcOfBorg GrahamcOfBorg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jammerful @copumpkin @GrahamcOfBorg @Mic92