notify-desktop: init at 0.2.0 #30747
Conversation
| longDescription = "It's basically clone of notify-send from libnotify, but it supports reusing notifications on screen by passing its ID. It also does not use any external dependencies (except from libdbus of course)."; | ||
| homepage = "https://github.com/nowrep/notify-desktop"; | ||
| license = licenses.gpl2; | ||
| platforms = platforms.all; |
There was a problem hiding this comment.
I think this should be platforms.linux because of dbus.
There was a problem hiding this comment.
Dbus it's not part of macos however it can run on macos too.
The dbus packages has platforms.unix
I actually don't know if dbus can be successfully built with nix on macos.
| buildInputs = [ dbus pkgconfig ]; | ||
|
|
||
| installPhase = ''mkdir -p $out/bin | ||
| install -m 755 bin/notify-desktop $out/bin/notify-desktop''; |
There was a problem hiding this comment.
With '' strings, please format as follows:
installPhase = ''
foo
bar
baz
'';
|
@GrahamcOfBorg notify-desktop |
|
|
||
| meta = with stdenv.lib; { | ||
| description = "Little application that lets you send desktop notifications with one command."; | ||
| longDescription = "It's basically clone of notify-send from libnotify, but it supports reusing notifications on screen by passing its ID. It also does not use any external dependencies (except from libdbus of course)."; |
There was a problem hiding this comment.
Please split into multiple lines, e.g.
longDescription = ''
It's basically clone of notify-send from libnotify, but it
supports reusing notifications on screen by passing its ID. It
also does not use any external dependencies (except from libdbus
of course).
'';
| install -m 755 bin/notify-desktop $out/bin/notify-desktop''; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| description = "Little application that lets you send desktop notifications with one command."; |
There was a problem hiding this comment.
Remove period from end of description. See 8.1. Standard meta-attributes.
|
Looks good to me now but please squash the two commits into a single one having the commit message "notify-desktop: init at 0.2.0". |
ylwghst
force-pushed
the
submit/notify-desktop
branch
from
ed1c8c2
to
592e9fc
Compare
notify-desktop package added improved code synopsis
ylwghst
force-pushed
the
submit/notify-desktop
branch
from
592e9fc
to
f832665
Compare
|
I just renamed the branch. |
|
Renaming a branch after opening a PR is not very good. Please open a new PR for the new branch and refer back to this PR. |
|
Sorry for that. It's my first build. I just want to have it it better organized for future tasks. |
|
No problems. Mainly good to know for the future. In any case, your commit is now in master. Thanks for the submission! :-) |
Motivation for this change
I'm customizing a WM and I needed to test out some UI functionality this kind of utility, but there wasn't
any available in the nixpkgs repository.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)