Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shotwell: 0.26.2 -> 0.27.0 #30740

Merged
merged 1 commit into from Oct 24, 2017
Merged

shotwell: 0.26.2 -> 0.27.0 #30740

merged 1 commit into from Oct 24, 2017

Conversation

mimame
Copy link
Member

@mimame mimame commented Oct 23, 2017

Motivation for this change

Update shotwell to the last version

  • Remove F-Spot import support
  • Create a commandline utility to test image transformations
  • Speed up color transformations a bit
  • Bump GTK+ requirement to 3.18 and remove deprecated functions
  • Clean-up histogram drawing code
  • Run thumbnailer with nice 19
  • Update VAAPI blacklisting for video thumbnailer and new plugin structure
  • Add configurable image background
  • Split several dialogs from shotwell.ui file
  • Move Tumblr to default plugin set
  • Remove some unnecessary memcpys on import
  • Add Meson build support
  • Some more ngettext for plurals
  • Add --fullscreen/-f option for viewer
  • Add option to install Ubuntu apport hook
  • Fix issue when importing to NTFS-backed vboxfs
  • Fix GSettings schema search path for running out-of-tree
  • Work around "Camera locked: -53" error on GNOME
  • Fix issue with missing highlight on dnd actions
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bjornfor
Copy link
Contributor

AFAIK, 0.27.x is unstable, 0.26.x is stable. (Just FYI... I haven't looked into how (un)stable those variants are.)

@mkocha2
Copy link

mkocha2 commented Oct 24, 2017

Stable versions of Shotwell are a danger to your data too. I am not aware of any photo solution on Linux that doesn't have a history of data loss. I switched to Digikam, but it too has a history of data loss, just slightly less.

Perhaps we should include a warning message in the description that it's pointless to try to create tags in Shotwell manually without some elaborate non-existing backup in place.

I think it's rather anti-social behaviour to "give away" "Free software" that results in material loss of property for most users. NixOS contributes to this by packaging Shotwell.

https://bugzilla.gnome.org/buglist.cgi?bug_status=__open__&content=shotwell&no_redirect=1&order=Importance&product=shotwell&query_format=specific seems to suggest that Shotwell is not maintained.

Shotwell suffers from:

  • index corruption
  • meta-data deletion
  • crashes during mere browsing
  • slow imports
  • a broken data model

I am in favor of protecting users against themselves and I think it's disappointing that you do not seem to share that approach.

@domenkozar
Copy link
Member

domenkozar commented Oct 24, 2017 •
edited by grahamc

@GrahamcOfBorg shotwell

GrahamcOfBorg
GrahamcOfBorg approved these changes Oct 24, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

shrinking /nix/store/hvw6sf4rjdw2q2cmkgbvmyndj3zgna29-shotwell-0.27.0/lib/shotwell/plugins/builtin/shotwell-transitions.so
shrinking /nix/store/hvw6sf4rjdw2q2cmkgbvmyndj3zgna29-shotwell-0.27.0/lib/shotwell/plugins/builtin/shotwell-publishing-extras.so
shrinking /nix/store/hvw6sf4rjdw2q2cmkgbvmyndj3zgna29-shotwell-0.27.0/bin/.shotwell-wrapped
shrinking /nix/store/hvw6sf4rjdw2q2cmkgbvmyndj3zgna29-shotwell-0.27.0/libexec/shotwell/.shotwell-video-thumbnailer-wrapped
gzipping man pages under /nix/store/hvw6sf4rjdw2q2cmkgbvmyndj3zgna29-shotwell-0.27.0/share/man/
stripping (with flags -S) in /nix/store/hvw6sf4rjdw2q2cmkgbvmyndj3zgna29-shotwell-0.27.0/lib  /nix/store/hvw6sf4rjdw2q2cmkgbvmyndj3zgna29-shotwell-0.27.0/libexec  /nix/store/hvw6sf4rjdw2q2cmkgbvmyndj3zgna29-shotwell-0.27.0/bin
patching script interpreter paths in /nix/store/hvw6sf4rjdw2q2cmkgbvmyndj3zgna29-shotwell-0.27.0
/nix/store/hvw6sf4rjdw2q2cmkgbvmyndj3zgna29-shotwell-0.27.0/libexec/shotwell/.shotwell-settings-migrator-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/h404wfcz8rzzlq8vr4z7plcijwzfci72-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-shotwell-0.27.0.drv-0 in /nix/store/hvw6sf4rjdw2q2cmkgbvmyndj3zgna29-shotwell-0.27.0...
/nix/store/hvw6sf4rjdw2q2cmkgbvmyndj3zgna29-shotwell-0.27.0

@domenkozar domenkozar merged commit 5715f27 into NixOS:master Oct 24, 2017
@bjornfor
Copy link
Contributor

From shotwell mailing list just now:

0.27.0 is broken and will corrupt your data on camera import. 0.27.1 should be ok. (https://mail.gnome.org/archives/shotwell-list/2017-October/msg00016.html)

Also, earlier in the thread they recommend to stay with 0.26.x unless there is a specific feature you need from 0.27.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamcOfBorg GrahamcOfBorg GrahamcOfBorg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mimame @bjornfor @mkocha2 @domenkozar @GrahamcOfBorg