Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/firewall: Rename misleading rejected to refused in logging #30324

Merged
merged 1 commit into from Oct 13, 2017

Conversation

florianjacob
Copy link
Contributor

as that's used as general term for rejected or dropped packets
in the rest of the config.

Motivation for this change

I was very irritated when I checked the journal of a NixOS server, as the inevitable port scans were logged as connection rejected, implying an ICMP port unreachable was sent as an answer and despite dropping was the default action.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

as that's used as general term for rejected or dropped packets
in the rest of the config.
@Mic92 Mic92 merged commit b90f508 into NixOS:master Oct 13, 2017
@Mic92
Copy link
Member

Mic92 commented Oct 13, 2017

Thanks!

@florianjacob florianjacob deleted the firewall-clarify-logging branch October 13, 2017 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants