Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize all constants in CipherStrings as public final static #146

Merged
merged 1 commit into from
Oct 12, 2017
Merged

Normalize all constants in CipherStrings as public final static #146

merged 1 commit into from
Oct 12, 2017
+10 −10

Conversation

drcapulet
Copy link
Contributor

No description provided.

@kares
Copy link
Member

kares commented Oct 12, 2017

thx, do you need to depend on these? (we could use PR's description on the reasons behind the change)
generally like to expose as little as possible, but if its useful (seems so) than o.k.

@drcapulet
Copy link
Contributor Author

No technical reason for these being public, just normalized them to make the code a little more readable.

@kares kares merged commit ec307fa into jruby:master Oct 12, 2017
@drcapulet drcapulet deleted the alexc-public branch October 12, 2017 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drcapulet @kares