Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libmsgpack/libtoxcore/qtox: several related package upgrades #30318

Merged
merged 5 commits into from Nov 9, 2017
Merged

libmsgpack/libtoxcore/qtox: several related package upgrades #30318

merged 5 commits into from Nov 9, 2017

Conversation

peterhoeg
Copy link
Member

@peterhoeg peterhoeg commented Oct 11, 2017 •
edited

Motivation for this change

This change carries a number of other changes that arose as a consequence of the libmsgpack change.

nox-review fails but that is because pjsip fails and thus ring-daemon which was the case anyway.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@peterhoeg
Copy link
Member Author

Cc: @redbaron @wkennington @viric @jgeerds @akaWolf

@akaWolf
Copy link
Member

akaWolf commented Oct 11, 2017

The name of PR does not reflect essence of the PR itself. Pls fix.

@peterhoeg peterhoeg changed the title qtox: 1.11.0 -> 1.12.1 libmsgpack/libtoxcore/qtox/utox: several related package upgrades Oct 12, 2017
@orivej
Copy link
Contributor

orivej commented Nov 6, 2017

utox has been updated in #31072, this PR needs rebasing.

@peterhoeg peterhoeg changed the title libmsgpack/libtoxcore/qtox/utox: several related package upgrades libmsgpack/libtoxcore/qtox: several related package upgrades Nov 6, 2017
@fpletz fpletz merged commit 7245002 into NixOS:master Nov 9, 2017
@orivej
Copy link
Contributor

orivej commented Nov 9, 2017

qtox hash fails to validate:

output path ‘/nix/store/h5bq81pk7qxj1d5aa3svsaishmjcxigh-source’ has r:sha256 hash ‘1l1k8s10jj6nm9i33m8xhjwdhikvp7csdp6x1gxjxdj526aak8q9’ when ‘1832ay0167qjc2vvpps507mnb0531y3d3pxmlm5nakvcwjs7vl8d’ was expected

@peterhoeg
Copy link
Member Author

No idea what happened here, but fix in 1529295

@peterhoeg peterhoeg deleted the u/qtox branch November 9, 2017 13:12
@vcunat vcunat mentioned this pull request Nov 17, 2017
Merged
8 tasks
@peterhoeg peterhoeg restored the u/qtox branch November 26, 2017 16:28
@peterhoeg peterhoeg deleted the u/qtox branch March 5, 2018 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@peterhoeg @akaWolf @orivej @fpletz @GrahamcOfBorg