Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snapcast: init at 0.11.1 #30323

Closed
wants to merge 2 commits into from
Closed

snapcast: init at 0.11.1 #30323

wants to merge 2 commits into from

Conversation

TealG
Copy link
Contributor

@TealG TealG commented Oct 11, 2017

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@peterhoeg
Copy link
Member

The server and client derivations are ALMOST exactly the same - please use a function instead. You can use this as a reference: https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/compilers/vala/default.nix

@pSub
Copy link
Member

pSub commented Jul 13, 2018

@TealG Are you still interested in this and working on it?

@peterhoeg
Copy link
Member

@fpletz added this in 4d37ce9

@peterhoeg peterhoeg closed this Jul 14, 2018
@pSub
Copy link
Member

pSub commented Jul 14, 2018

@peterhoeg Thank you for spotting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
9.needs: clean-up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@TealG @peterhoeg @pSub @orivej @Mic92