Init create-elm-app, elm-oracle and elm-test #30320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
periklis
force-pushed
the
init-elm-utilities
branch
from
9d7d314
to
f898992
Compare
periklis
changed the title
|
maybe ping @garbas for review? |
periklis
force-pushed
the
init-elm-utilities
branch
5 times, most recently
from
2c120ed
to
dfed137
Compare
|
ping @domenkozar |
|
I can't really review this PR due to the node package changes. |
|
It would make more sense to package them via elm. @periklis any reason not to do that? |
|
@domenkozar i was not aware that elm2nix works yet. How do i package them via elm in nixpkgs? |
|
See pkgs/development/compilers/elm/packages/
…On Tue, Oct 17, 2017 at 1:38 PM, Periklis Tsirakidis < ***@***.***> wrote:
@domenkozar <https://github.com/domenkozar> i was not aware that elm2nix
works yet. How do i package them via elm in nixpkgs?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#30320 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAHtg5LVkPqB-QoRYwCxIBrM2KX0KKjnks5stJ-ngaJpZM4P1t7Y>
.
|
|
But these are all packages written in haskell and not in javascript the proposed three packages in this PR. |
|
Maybe you mean to add them like in an attrset like reactor-elm.nix |
periklis
force-pushed
the
init-elm-utilities
branch
from
dfed137
to
db7b42d
Compare
periklis
force-pushed
the
init-elm-utilities
branch
from
db7b42d
to
d34eed8
Compare
|
i'll drop this PR, since focus shifted again and it needs major rework to put the packages under |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Three packages namely create-elm-app, elm-oracle and elm-test to enable elm development.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)