Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

palemoon: 27.4.2 -> 27.5.0 #30327

Merged
merged 1 commit into from Oct 13, 2017
Merged

palemoon: 27.4.2 -> 27.5.0 #30327

merged 1 commit into from Oct 13, 2017

Conversation

JamesTheAwesomeDude
Copy link
Contributor

27.5.1 is "out", but there is no GitHub Release

(Although, this shouldn't be an issue since it was
mostly Win10-only changes anyway)

Motivation for this change

I use this browser every day

Things done

Version bump with hash update; built successfully and am posting from the very built browser

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@JamesTheAwesomeDude
palemoon: 27.4.2 -> 27.5.0
67ae0fa 
27.5.1 is "out", but there is no GitHub Release

(Although, this shouldn't be an issue since it was
mostly Win10-only changes anyway)
@JamesTheAwesomeDude
Copy link
Contributor Author

It is almost identical to the previous version bump, 460cd80

@joachifm
Copy link
Contributor

cc @rnhmjoj

rnhmjoj
rnhmjoj approved these changes Oct 13, 2017
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@joachifm joachifm merged commit 6e7f35c into NixOS:master Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

Assignees
No one assigned
Labels
12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JamesTheAwesomeDude @joachifm @rnhmjoj @Janik-Haag