nixos/krb5: complete rewrite #30014
nixos/krb5: complete rewrite #30014
Conversation
The `krb5` service was a bit lacking. Addresses NixOS#11268, partially addresses NixOS#29623.
|
Tests looks ok, but maybe launching a vm is not necessary. @Profpatsch do you have a better idea here? |
| example = "ATHENA.MIT.EDU"; | ||
| description = '' | ||
| DEPRECATED, please use | ||
| <literal>krb5.libdefaults.default_realm</literal>. |
There was a problem hiding this comment.
Are you aware of nixos/modules/rename.nix?
There was a problem hiding this comment.
As far as I can tell, this only forwards definitions for deprecated options that have a one-to-one mapping to non-deprecated options (or just prints a warning saying what to do). Do you think it's worth it to use mkRenamedOptionModule for the only deprecated option that does have a one-to-one relationship with a non-deprecated option (the one you commented on), or to go all in on mkRenamedOptionModule and say that those deprecated options are no longer supported at all?
There was a problem hiding this comment.
Yeah probably not that useful here.
There was a problem hiding this comment.
That's how I feel about it too, but not strongly - I would be happy to change it if that is the preferred way of doing things!
There was a problem hiding this comment.
I added a deprecation date instead
|
I successfully transformed my old krb5 configuration to the new module syntax: Mic92/dotfiles@b96e0b7 |
|
Nice work. I also gave up on the old module back then and used the configuration file instead. |
|
Thanks!! |
For service modules it’s kind of hard to test the correct functionality without a NixOS VM. :) |
Motivation for this change
The
krb5service was a bit lacking.Addresses #11268, partially addresses #29623.
I've made an effort to accommodate people who are using the old configuration keys.
Given the state that it was in though, I wonder anyone even used this module.
Also I'm not sure if this is an abuse of the testing framework. Snapshot testing is something I do a lot of in web development so it makes sense to me to try it here.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)