Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nasm: run checkPhase #30006

Merged
merged 1 commit into from Oct 2, 2017
Merged

nasm: run checkPhase #30006

merged 1 commit into from Oct 2, 2017

Conversation

WilliButz
Copy link
Member

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej orivej changed the base branch from master to staging October 1, 2017 23:48
@WilliButz WilliButz changed the base branch from staging to master October 1, 2017 23:53
@WilliButz
Copy link
Member Author

@orivej excuse me changing it back to master, looked like something was wrong.
Why does this need to be merged into staging? :)

@WilliButz WilliButz closed this Oct 1, 2017
@WilliButz WilliButz reopened this Oct 1, 2017
@orivej
Copy link
Contributor

orivej commented Oct 1, 2017

Because it rebuilds 4000 packages on Linux.

@orivej
Copy link
Contributor

orivej commented Oct 1, 2017

Could you rebase this on top of staging?

@WilliButz WilliButz changed the base branch from master to staging October 1, 2017 23:59
@WilliButz
Copy link
Member Author

WilliButz commented Oct 2, 2017 •
edited

@orivej could you remove the review requests? :)
(I guess they where made in the short time between me pushing the rebased branch with a lot of changes compared to master and me switching the target branch staging)

@WilliButz WilliButz closed this Oct 2, 2017
@WilliButz WilliButz reopened this Oct 2, 2017
@orivej orivej merged commit 21976d1 into NixOS:staging Oct 2, 2017
@orivej
Copy link
Contributor

orivej commented Oct 2, 2017

Merged into staging. Thank you!

@WilliButz WilliButz deleted the nasm-run-tests branch February 1, 2018 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WilliButz @orivej