gnome3.gnome_control_center: fix thumbnailers path #29983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just like Nautilus (see NixOS#29970), GNOME Control Center also uses gnome-desktop for generating thumbnails. In particular, it tries to make a thumbnail from a file choosen as a profile picture, and when it does not succeed, it will not allow that file to be chosen. Of course, whithout a thumbnailer, it will always fail. https://github.com/GNOME/gnome-control-center/blob/43129a1cfd30374c3ff45c54eae9ee5cd68ae1b6/panels/user-accounts/um-photo-dialog.c#L190-L192 Since gnome-desktop scans `thumbnailers` directories under the paths in `XDG_DATA_DIRS`, gdk-pixbuf had to be added to the path to provide access to image thumbnailer.
This was referenced Oct 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Just like Nautilus (see #29970), GNOME Control Center also uses gnome-desktop for generating thumbnails. In particular, it tries to make a thumbnail from a file choosen as a profile picture, and
when it does not succeed, it will not allow that file to be chosen. Of course, whithout a thumbnailer, it will always fail.
https://github.com/GNOME/gnome-control-center/blob/43129a1cfd30374c3ff45c54eae9ee5cd68ae1b6/panels/user-accounts/um-photo-dialog.c#L190-L192
Since gnome-desktop scans
thumbnailersdirectories under the paths inXDG_DATA_DIRS, gdk-pixbuf had to be added to the path to provide access to image thumbnailer.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)cc @lethalman @teh @grahamc